Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: GitHub action for notification #98

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mj52951
Copy link
Collaborator

@mj52951 mj52951 commented Mar 25, 2024

Added a GitHub action for notifying Sygma partners on Slack when files shared-config-mainnet.json or shared-config-test.json are modified. Also, for every PR that you want the Slack message to be sent, it will be needed to set the Restart Relayers label.

Currently it is not supported by the Slack API to use one webhook for sending messages to multiple channels. So, it will be needed to add both SLACK_WEBHOOK_URL1 and SLACK_WEBHOOK_URL2 repository variables for it to properly work for 2 channels. Accordingly, it will be needed to add more variables if the notification needs to be sent to more channels.

closes #95

@mj52951 mj52951 changed the title chore: GitHub action for Sygma partners notification chore: GitHub action for notification Mar 25, 2024
@mj52951
Copy link
Collaborator Author

mj52951 commented Mar 25, 2024

This is how the notification looks like on Slack

notifimg

@mj52951 mj52951 marked this pull request as draft March 28, 2024 11:06
@mj52951
Copy link
Collaborator Author

mj52951 commented Apr 8, 2024

This is how the updated notification looks like.

notif

@mj52951 mj52951 marked this pull request as ready for review April 8, 2024 12:58
Copy link
Contributor

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow trigger on-demand (tag, label...) ?
Most of the PRs don't actually require a relayer restart and are not changes that the partners should know about.

@mj52951
Copy link
Collaborator Author

mj52951 commented Apr 11, 2024

Updated notification with separate checks for mainnet and testnet changes.

sygma-notif

@mj52951 mj52951 requested a review from mpetrun5 April 16, 2024 07:04
@MakMuftic MakMuftic added Restart Relayers Triggers action to notify for all relayers to restart and removed Restart Relayers Triggers action to notify for all relayers to restart labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github action for sygma partners notification
3 participants