Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement keyed priority queue #97

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Implement keyed priority queue #97

wants to merge 8 commits into from

Conversation

daun
Copy link
Member

@daun daun commented Aug 21, 2023 •
edited
Loading

Description

  • Re-implement throttled queue as class with keyed Maps
  • Goal: key jobs by URL to allow handing out Promises
  • Replace the job queue and the preloadPromises Map to a single this.queue

Other changes

  • Switch to async-await for adding the PageData promise

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Additional information

Closes #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundling error with webpack
1 participant
@daun