Added GPSExtendedStatus msg to allow for additional status enums #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me as well. |
danthony06
approved these changes
May 9, 2024
This was referenced May 9, 2024
Closed
|
Great, thanks for moving on with this! I also suggest to add a reference to the extended fix as a comment to GPSFix. Adding comments doesn't change MD5 sum of the message type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add RTK Fix/Float into the GPSStatus message, but #34 already attempted to do this. The drawback is that the md5sum would change and it would potentially be burdensome to all users with previous bag data.
I think a reasonable workaround is the approach I have here. I added a new message that only defines enums. This way anyone can use the extended enums if they wish and they'll be standardized.