Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‼️ Hotfix: Allow graph creation with empty nodes and links ‼️ #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krusche
Copy link

@krusche krusche commented Nov 9, 2024

What kind of change does this PR introduce? (check one with "x")

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
At the moment, graphs with 0 nodes or 0 links crash the component with undefined errors, because the graph is not created and this.graph.nodes is still invoked

What is the new behavior?
Graphs with 0 nodes or 0 links can be used without undefined errors. Closes #559

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Other information:
Please merge this PR asap and create a bugfix release 9.0.2 as we currently cannot upgrade to 9.x

@krusche krusche changed the title Allow graph creation with empty nodes and links ‼️ Hotfix: Allow graph creation with empty nodes and links ‼️ Nov 9, 2024
@krusche
Copy link
Author

krusche commented Nov 15, 2024

@steveblue any chance you merge this quickly and create a 9.0.2 release?

1 similar comment
@krusche
Copy link
Author

krusche commented Dec 7, 2024

@steveblue any chance you merge this quickly and create a 9.0.2 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph crashes when no links or nodes are provided
1 participant