Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Aurora USDT with USDT.e #474

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Replace Aurora USDT with USDT.e #474

wants to merge 7 commits into from

Conversation

swimdrew
Copy link
Contributor

@swimdrew swimdrew commented Oct 28, 2022 •
edited
Loading

Resources on how USDT.e should appear:

Notion ticket

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@swimdrew swimdrew changed the title UI/add usdte Replace Aurora USDT with USDT.e Oct 28, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9594560
Status:🚫  Build failed.

View logs

@swimdrew swimdrew added the improvement Improving an existing feature label Oct 28, 2022
@swimdrew swimdrew requested a review from wormat October 28, 2022 16:18
@swimdrew swimdrew marked this pull request as ready for review October 28, 2022 16:18
@swimdrew
Copy link
Contributor Author

Just to confirm, the path to merging is..

  1. Get approval package code
  2. Publish package
  3. Modify package.json for /apps
  4. Get approval for /apps
  5. Merge PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat Awaiting requested review from wormat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
improvement Improving an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swimdrew