evm-contracts/deployment-audit-xhack #472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployment * audit: add missing whenNotPaused modifier * audit: fix amp factor logic in Pool * audit: emit additional events in Routing and Pool * fix: throw in propellerComplete() when not a Propeller transaction * fix: cap remunerated gas price by tx.gasprice * feat: make remunerated Propeller gas price depend on specific chain * feat: implement Decimal interface for fixedSwimUsdPerGasToken * feat: expose Wormhole nonce in function signatures for upcoming BatchVAAs * feat: catch Panic thrown by failed Wormhole interactions * feat: compile contracts using viaIR optimization * chore: improve gas estimation for Propeller gas fee remuneration * chore: have registerToken() clean up old registrations and check inputs * chore: clean-up and relocate contract structs, enums, events, and constants * chore: update constants after deployment
* feat: use token-projects package to determine token numbers * feat: use pool-math package for testing to replace hardcoded values * feat: include attestation of SwimUSD in deployment process when possible * feat: implement MOCK for Routing contract itself to isolate pool tests * refactor: replace BigNumber with more suited Decimal in test code * refactor: further improve test code and Wrapper classes
swimivan
added
bug
Deploying with
|
| Latest commit: |
9843e55
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6373d22.swim-ui.pages.dev |
| Branch Preview URL: | https://evm-contracts-deployment-aud-wga2.swim-ui.pages.dev |
|
✨ Deployment complete! Take a peek over at https://da62a50d.ui-storybook.pages.dev |
arvakr
reviewed
Oct 27, 2022
| print("---------------------") | ||
| return [fr_profit, user_output] | ||
|
|
||
| def profitability_threshold(swap_amount, debug=False): |
| @@ -0,0 +1,3 @@ | |||
| MNEMONIC=test test test test test test test test test test test junk | |||
| FACTORY_MNEMONIC=try exercise column boring supreme corn fabric idea federal today hood equip | |||
| uint64 serviceFee; //specified in swimUSD | ||
| //service fee specified in swimUSD | ||
| uint64 serviceFee; | ||
| //specified in atomic with 18 decimals, i.e. how many atomic swimUSD per 1 wei? |
There was a problem hiding this comment.
I'd have put a new line above, just to make sure it's not accidentally read as relating to serviceFee
| @@ -393,12 +485,16 @@ contract Routing is | |||
| toTokenInfo = tokenNumberMapping[swimPayload.toTokenNumber]; | |||
| if (toTokenInfo.tokenNumber != 0) { | |||
| //if toTokenNumber in swimPayload was invalid for whatever reason then just return | |||
| //swimUsd to prevent propeller transaction from getting stuck | |||
| // swimUsd to prevent propeller transaction from getting stuck | |||
There was a problem hiding this comment.
Curious about the added space? I prefer this but most other comments don't have a leading space
There was a problem hiding this comment.
I use the indentation to signify "same paragraph" or even more generally to indicate that the line break is only a "line wrap".
| } | ||
|
|
||
| function setup(address[] calldata tokens_, uint[] calldata amounts_) external { | ||
| require(msg.sender == _owner, "computer says no"); |
| @@ -12,10 +12,11 @@ import { task } from "hardhat/config"; | |||
| import type { HardhatUserConfig, HttpNetworkUserConfig } from "hardhat/types"; | |||
|
|
|||
| dotenv.config(); | |||
| //update .env.examples if you add additional environment variables! | |||
| @@ -38,6 +39,7 @@ task( | |||
| async ({ proxy, logic, owner }, hre) => { | |||
| const { ethers } = hre; | |||
| const _owner = owner ? await ethers.getSigner(owner as string) : (await ethers.getSigners())[0]; | |||
| //TODO check that proxy and logic exist | |||
There was a problem hiding this comment.
Correct to still be a todo?
There was a problem hiding this comment.
not anymore in a second
| ? 0 | ||
| : Object.values(TokenProjectId) | ||
| .map((id) => TOKEN_PROJECTS_BY_ID[id]) | ||
| //TODO we're using includes() and lenght checking here instead of === here because e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed version of #463 which accidentally included changes to pool-math package
see individual commit messages for an overview of the introduced changes
Checklist