Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build check natively in bazel #64

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

build check natively in bazel #64

wants to merge 5 commits into from

Conversation

wwieclaw
Copy link
Contributor

@wwieclaw wwieclaw commented Apr 3, 2023

The configuration has been copied from a CMake build that I ran in a container from a minimal Dockerfile:

FROM debian:buster-slim

RUN apt-get update\
    && apt-get install -y make cmake clang binutils gcc

WORKDIR /mnt/workspace

CMD ["/bin/bash"]

Testing

libsbp
libswiftnav-private ✅ (github actions are broken, but bazel stages passed)
gnss-converters-private ✅ (github actions are broken, but bazel stages passed)

JIRA

https://swift-nav.atlassian.net/jira/software/projects/BUILD/boards/227?selectedIssue=BUILD-645

Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Before we merge this we'll need to figure something out for aarch64-darwin and x86_64-darwin.

If we could figure out some way to fall back to continuing to use the cmake build on those platforms I think that would be fine for now.

@wwieclaw
Copy link
Contributor Author

wwieclaw commented Apr 3, 2023

@isaactorz updated description with PRs for gnss-converters and libswifnav. Note that some of the jobs got cancelled due to use of deprecated env images

@wwieclaw
Copy link
Contributor Author

wwieclaw commented Apr 3, 2023

Looks great.

Before we merge this we'll need to figure something out for aarch64-darwin and x86_64-darwin.

If we could figure out some way to fall back to continuing to use the cmake build on those platforms I think that would be fine for now.

@isaactorz I've updated my libsbp PR to fall back to cmake build on mac. I've yet to successfully build libswiftnav and gnss-converters-private this way, but I leave that for tomorrow.

Copy link
Contributor

@krisukox krisukox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me give this a quick build on the macs and then we can merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants