Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "semicolon" translation #385

Merged

Conversation

pavilandoangelo
Copy link
Contributor

No description provided.

@pavilandoangelo
Copy link
Contributor Author

Hi @dk3775 , added a translation. Added it also in the test file to made it sure it will pass. Let me know if there is anything I could improve. Thank you.

@dk3775
Copy link
Collaborator

dk3775 commented Oct 3, 2022

Hey @pavilandoangelo thanks for this. You can also contribute at this issue #351

@pavilandoangelo
Copy link
Contributor Author

Hi @dk3775 , I'll look into it. Thank you!

Copy link
Collaborator

@dk3775 dk3775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@dk3775 dk3775 merged commit f7d14db into swapagarwal:master Oct 3, 2022
@pavilandoangelo
Copy link
Contributor Author

Hi @dk3775 , can you please add the label hacktoberfest-accepted? That would be mean a lot for me. I'm just starting out contributing to open source and I want to continue it with a good first experience. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants