Allow providing multiple BeforeScript and AfterScript #80
+54
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhomart
changed the title
Summary:
Previsouly this code would allow only a single script to run:
```
r.Get("/swagger/*", httpSwagger.Handler(
httpSwagger.BeforeScript("console.log('before 1')"),
httpSwagger.BeforeScript("console.log('before 2')"),
httpSwagger.URL("http://localhost:1323/swagger/doc.json"), //The url pointing to API definition
))
// Only 'before 2' will be printed
```
Now both scripts are run:
```
'before 1'
'before 2'
```
This improves behavior of BeforeScript and AfterScript. If users
want to provide multiple scripts, they are forced to combine them using
strings.
Closes swaggo#81
Test Plan: Updated existing example and tests. Added new test TestMultipleScripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow providing multiple BeforeScript and AfterScript
Summary:
Previsouly this code would allow only a single script to run:
Now both scripts are run:
This improves behavior of BeforeScript and AfterScript. If users
want to provide multiple scripts, they are forced to combine them using
strings.
Closes #81
Test Plan: Updated existing example and tests. Added new test TestMultipleScripts
Stack created with Sapling. Best reviewed with ReviewStack.