Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reflect SvelteURLSearchParams changes to SvelteURL #12285

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

FoHoOV
Copy link
Contributor

@FoHoOV FoHoOV commented Jul 3, 2024

Currently any change to SvelteURL.searchParams is not reflected on SvelteURL directly. This PR separates url-search-params and url into different files (just like other classes) and adds more tests (also reduces the number of redundant updates).

fixes URL part of #11727 (meaning this where changes to search params is not reflected on url)

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: fb1514b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FoHoOV
Copy link
Contributor Author

FoHoOV commented Jul 3, 2024

Ofc, why not, node 18.20s implementation is somehow screwing with me. Maybe its using ctx.search instead of ctx.searchPrams? Idk I'll look into it later :(

Edit: yep it does, searchParams are in sync, but url.search is not in sync with url.searchParams 🗡️ 🗡️ 🗡️ they use different things internally on node18.20

@FoHoOV FoHoOV marked this pull request as ready for review July 3, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant