fix: include named exports in svelte 5 type #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good 👍 you can add |
Oh gotcha...will update then. P.s. I know this repo is less contributor friendly to begin with but I think we should try to write those things somewhere 😌 |
|
Totally agree, a contribution guide is needed |
dummdidumm
approved these changes
Oct 9, 2024
I'll try to write down something as soon as i can but i will probably need a lot of feedback since as you've seen i'm missing some info 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix sveltejs/svelte#13508
I'm missing writing and fixing the tests but i'm pushing this already so that it can be validated. I'll fix tests and write new later.
EDIT: while working on this i noticed that even if a component had
<svelte:options runes />it was still exporting like if it was not in rune mode. A bit of digging led me to the discovery that that option was never read. I added this but i don't know if i misunderstood something.Also i write some new test and despite the fact that it's just for runes is still requiring an
expectedv2file which seems a bit weird...is there some configuration i need to set to prevent this?