Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to v2 Embedding #99

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: Migrate to v2 Embedding #99

merged 1 commit into from
Aug 28, 2024

Conversation

Sadhorsephile
Copy link
Contributor

Changes

  • Remove v1 Embedding Support
  • Add more info about Android Testing to README.md

Checklist

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Attached videos/screenshots demonstrating the fix/feature.
  • Have you run the tests locally to confirm they pass?

@Sadhorsephile Sadhorsephile added the enhancement New feature or request label Aug 28, 2024
@Sadhorsephile Sadhorsephile self-assigned this Aug 28, 2024
Copy link

Link to Pyrus task

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (4a646c6) to head (3aad2cb).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files           4        4           
  Lines          82       82           
=======================================
  Hits           79       79           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sadhorsephile Sadhorsephile merged commit d070e5e into main Aug 28, 2024
10 checks passed
@Sadhorsephile Sadhorsephile deleted the SNP-1815-v2-migration branch August 28, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to deprecated v1 Android embedding
3 participants