feat: Support for environment variables in config.yaml #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Change
This PR adds support for environment variables in config.yaml. This implementation allows environment variables to be specified with
${ENV_VAR}
, whereENV_VAR
is the name of the variable to use.Implementation Details
}
or linebreak, since the allowed characters for environment variables likely vary by OS${ENV_VAR_A}
and the value ofENV_VAR_A
is${ENV_VAR_B}
, this will not output the value ofENV_VAR_B
, but will instead output the string${ENV_VAR_B}
QuitProgramException
is thrown if an environment variable in the config is not defined\
\${ENV_VAR}
would output the string${ENV_VAR}
, not the value of the environment variableENV_VAR
Additional Proposed Features
${ENV_VAR, 0}
would try to getENV_VAR
and would output0
if not defined|
,:
, something else?)host
could default to${SUPERTOKENS_HOST, 0.0.0.0}
${file: ../db_config.yaml}
Examples
Related Issues
(no related issues)
Test Plan
I have looked into ways of mocking environment variables. Java does not allow directly mocking calls to
System.getenv()
, so I could either extract that call into a mockable class, or we could consider using processes instead of threads for testing. Environment variables are immutable for the current process (including threads), but they could be modified when launching a subprocess (see ProcessBuilder.environment()).Documentation changes
If implemented, the configuration file should probably get its own page in the documentation to explain the various usages of this syntax. Let me know where this page should go, or if it should be added to an already existing page. I can submit a PR once the implementation of this feature is finalized.
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)pluginInterfaceSupported.json
file has been updated (if needed)build.gradle
build.gradle
, please make sure to add them inimplementationDependencies.json
.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.Remaining TODOs for this PR
${}
in comments (comments could easily be stripped before preprocessing)CoreConfig.java