Code cleaning #4359
Open
Code cleaning #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if there's none. supermerill/SuperSlicer/issues#778
|
I'm okay with removing warnings. |
supermerill
reviewed
Jul 9, 2024
|
ok, I understand the issue when merging from Prusa. I'll prepare a cleaner pull request for the elimination of warnings. |
|
I work on the OrcaSlicer project and I would LOVE to do this to Orca as well. Biggest issue is merging between the projects. Maybe we can get all of the Slic3r projects to agree on a clang-format standard and we could format all of the projects? In a perfect world :) |
supermerill
force-pushed
the
nightly_dev
branch
4 times, most recently
from
5e0f604
to
787415d
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
787415d
to
5dc2ae8
Compare
supermerill
force-pushed
the
nightly_dev
branch
7 times, most recently
from
6919ee2
to
97361d8
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
97361d8
to
2aea702
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
f72d362
to
618bf81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits eliminate a lot of warnings while compiling (unused variables and functions, indenation, improper types). Inaddition there is one commit that does some cosmetics: remove trailing blanks and replaces tabs with 4 spaces.