Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated build system to tsup #570

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

mattpocock
Copy link
Contributor

@mattpocock mattpocock commented Aug 20, 2024

Also contains work in #569, merge that first.

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: d542050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mattpocock mattpocock changed the title Matt/migrated-build-system-to-tsup Migrated build system to tsup Aug 20, 2024
This was referenced Aug 20, 2024
Copy link
Contributor

@dmmulroy dmmulroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattpocock could you please add some context to why tsup is a good/better solution beyond just being "modern"? Thanks!

@supermacro @m-shaka I am a fan of tsup and in favor of this change once justification and context is added to the description

@mattpocock
Copy link
Contributor Author

The main appeal of tsup is that I trust the declaration files it generates. It also generates one per output type by default (which is recommended by Andrew Branch of the TS team) which means the exports map can be simpler.

If you're happy with your current rollup-based setup, that's fine - but it seemed a bit custom and funky so I thought a low-config, well-maintained option would make sense.

@supermacro
Copy link
Owner

refraining from diving into this PR until convo for #569 is clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants