feat: add partition static function #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @supermacro, Any thoughts about this one? Thanks! |
supermacro
reviewed
Aug 28, 2024
Comment on lines
+72
to
+78
| static partition< | ||
| T extends readonly [ResultAsync<unknown, unknown>, ...ResultAsync<unknown, unknown>[]] | ||
| >(asyncResultList: T): PartitionResultAsync<T> | ||
| static partition<T extends readonly ResultAsync<unknown, unknown>[]>( | ||
| asyncResultList: T, | ||
| ): PartitionResultAsync<T> | ||
| static partition<T extends readonly ResultAsync<unknown, unknown>[]>( |
There was a problem hiding this comment.
I'm not following why we need to overload this fn. Please explain.
There was a problem hiding this comment.
I think these overloads have no meaning.
partition will flatten tuple type to array of union by its nature.
Type checking of this test passes even if you remove overloads
https://github.com/supermacro/neverthrow/pull/526/files?w=1#diff-cece62ae24396a5d51e8f2a2cb3abba900652084488023f4de9669eaaf6f81e8R572-R579
|
Added help wanted as there are conflicts and unanswered comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
added
partitionfunction to handle scenarios when you need to get a tuple of all results and errors. Inspired by lodash partition