Makefile changes to get macOS/clang builds working. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superctr
requested changes
Aug 9, 2021
| @@ -7,6 +7,6 @@ CFLAGS += -DAUDDRV_WINMM -DAUDDRV_DSOUND -DAUDDRV_XAUD2 | |||
| LDFLAGS_LIBVGM += -Wl,-Bstatic -lvgm-audio -lvgm-emu -lvgm-utils -Wl,-Bdynamic | |||
| LDFLAGS_LIBVGM += -ldsound -luuid -lwinmm -lole32 | |||
| else | |||
| CFLAGS += `pkg-config --with-path=/usr/local/lib/pkgconfig --cflags vgm-audio` | |||
| LDFLAGS_LIBVGM += -Wl,-rpath,/usr/local/lib `pkg-config --with-path=/usr/local/lib/pkgconfig --libs vgm-audio vgm-emu` | |||
| CFLAGS += `pkg-config --cflags vgm-audio` | |||
There was a problem hiding this comment.
The "--with-path" is a parameter which is only supported in "pkgconf", an alternate implementation of pkg-config that is used by Arch Linux. Ideally we'd be able autodetect which version/implementation of pkg-config that is used to decide whether this should be specified or not.
| CFLAGS += `pkg-config --with-path=/usr/local/lib/pkgconfig --cflags vgm-audio` | ||
| LDFLAGS_LIBVGM += -Wl,-rpath,/usr/local/lib `pkg-config --with-path=/usr/local/lib/pkgconfig --libs vgm-audio vgm-emu` | ||
| CFLAGS += `pkg-config --cflags vgm-audio` | ||
| LDFLAGS_LIBVGM += -Wl,-rpath,/usr/local/lib `pkg-config --libs vgm-audio vgm-emu ao` -framework AudioToolbox |
There was a problem hiding this comment.
This will break other platforms since AudioToolBox is a Mac exclusive API.
| @@ -7,6 +7,6 @@ CFLAGS += -DAUDDRV_WINMM -DAUDDRV_DSOUND -DAUDDRV_XAUD2 | |||
| LDFLAGS_LIBVGM += -Wl,-Bstatic -lvgm-audio -lvgm-emu -lvgm-utils -Wl,-Bdynamic | |||
| LDFLAGS_LIBVGM += -ldsound -luuid -lwinmm -lole32 | |||
| else | |||
There was a problem hiding this comment.
You should add an if case for Mac builds here. See imgui.mak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I don't know if this will break other platforms, but here's what I did to get the build working on macOS (10.15.6 Catalina).
I think I also installed glfw and libao with Homebrew: