Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Supavisor application_name query #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

w3b6x9
Copy link
Member

@w3b6x9 w3b6x9 commented May 29, 2024

No description provided.

@w3b6x9 w3b6x9 requested review from chasers and abc3 May 29, 2024 01:36
@@ -40,7 +40,7 @@ select
usename,
application_name
from pg_stat_activity
where application_name ilike '%Supavisor%'
where application_name = 'Supavisor'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no point in doing ilike when we set it as Supavisor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a Supavisor auth_query one

@w3b6x9 w3b6x9 force-pushed the docs/application-name-query branch 2 times, most recently from bccf097 to 857b4c9 Compare May 29, 2024 01:45
@w3b6x9 w3b6x9 force-pushed the docs/application-name-query branch from 857b4c9 to 4c56def Compare May 29, 2024 02:45
@@ -40,7 +40,7 @@ select
usename,
application_name
from pg_stat_activity
where application_name ilike '%Supavisor%'
where application_name in ('Supavisor', 'Supavisor auth_query')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chasers including the auth query one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? Now we have to remember to add any here if we update them.

Copy link
Member

@abc3 abc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts with #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants