Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: used json.dumps instead of str in sanitize_params #161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aduuna
Copy link

@aduuna aduuna commented Oct 15, 2022

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

#131 Use json.dumps instead of str in sanitize_params

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 15, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.20%.

Quality metrics Before After Change
Complexity 0.60 ⭐ 0.60 ⭐ 0.00
Method Length 20.75 ⭐ 22.00 ⭐ 1.25 👎
Working memory 3.20 ⭐ 3.20 ⭐ 0.00
Quality 95.25% 95.05% -0.20% 👎
Other metrics Before After Change
Lines 16 18 2
Changed files Quality Before Quality After Quality Change
postgrest/utils.py 95.25% ⭐ 95.05% ⭐ -0.20% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@rawandahmad698
Copy link

looks good.

rawandahmad698
rawandahmad698 previously approved these changes Oct 21, 2022
Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, please fix them (you added the import statement above the future statement which causes a syntax error)

@J0
Copy link
Contributor

J0 commented Jan 23, 2023

Think we might need to update the test cases for this one as well - would be great if someone can jump on - otherwise I'll take a look when there's a free cycle

@J0
Copy link
Contributor

J0 commented Feb 11, 2023

Hey,

Going to fix the tests on this one so we can get it in - hope you don't mind!

@mansueli mansueli added the good first issue Good for newcomers label Feb 28, 2024
@silentworks silentworks requested a review from J0 as a code owner May 28, 2024 19:53
@silentworks
Copy link
Contributor

This will result in a breaking change at the moment. I've ran the tests and there are too many broken tests to get this into a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants