-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: used json.dumps instead of str in sanitize_params #161
base: main
Are you sure you want to change the base?
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.20%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, please fix them (you added the import statement above the future
statement which causes a syntax error)
Think we might need to update the test cases for this one as well - would be great if someone can jump on - otherwise I'll take a look when there's a free cycle |
Hey, Going to fix the tests on this one so we can get it in - hope you don't mind! |
This will result in a breaking change at the moment. I've ran the tests and there are too many broken tests to get this into a release. |
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
#131 Use json.dumps instead of str in sanitize_params
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.