Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix relationship 1:1 nullability #559

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Bugfix relationship 1:1 nullability #559

merged 4 commits into from
Sep 27, 2024

Conversation

olirice
Copy link
Contributor

@olirice olirice commented Sep 26, 2024

What kind of change does this PR introduce?

Bugfix. Reverse foreign key relationships are not known to be not null. This PR updates them to display nullability in Introspection schema. No transpilation behavior is changed.

Resolves #557

@olirice olirice requested a review from imor September 26, 2024 19:19
@imor
Copy link
Contributor

imor commented Sep 27, 2024

@olirice corrected a few fields in the test in my last commit. LGTM otherwise.

@olirice
Copy link
Contributor Author

olirice commented Sep 27, 2024

good edits, TY

@olirice olirice merged commit 8e0ca67 into master Sep 27, 2024
4 checks passed
@olirice olirice deleted the or/1-1-nullability branch September 27, 2024 13:38
@fourbytes
Copy link

Any news on when we can get this released and rolled out to hosted Supabase?

@olirice
Copy link
Contributor Author

olirice commented Oct 10, 2024

Working on a version bump here #565
after that merges it'll be 1-2 weeks before it shows up in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1:1 Relationship Nullability
3 participants