Resolves an issue where querying 100+ fields on a relationship causes a pg error #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesharper
changed the title
|
Sorry for the delay, I'll get this reviewed before EOW (aiming for tomorrow). Looks great at a glance! |
|
No worries, thanks for keeping up on it! |
olirice
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Resolves #551. Applies the same fix as #390, but for relational queries.
What is the current behavior?
See #551. Current behavior is querying a related entity with 100 fields breaks.
What is the new behavior?
Transpilation works and results are returned.
Additional context
I'm not yet familiar with Rust, so please use additional scrutiny.
While this would certainly unblock my team in the short-term, it seems like this issue indicates an area where a concerted refactor like recursively handling the to_sql operation may be more appropriate in the long run to avoid similar issues in the future.