Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps pgrx to support PG17 #552

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

davidgomes
Copy link
Contributor

What kind of change does this PR introduce?

This PR bumps the pgrx version to 0.12.4 so that PG17 can be supported.

What is the new behavior?

$ cargo pgrx run pg17
    Starting Postgres v17 on port 28817
     Creating database pg_graphql
psql (17rc1)
Type "help" for help.

david@pg_graphql=# create extension pg_graphql;
CREATE EXTENSION
Time: 371.664 ms
david@pg_graphql=# create table book(id int primary key, title text);
CREATE TABLE
Time: 16.246 ms
david@pg_graphql=# insert into book(id, title) values (1, 'book 1');
INSERT 0 1
Time: 3.510 ms
david@pg_graphql=# select graphql.resolve($$
[more] $> query {
[more] $>   bookCollection {
[more] $>     edges {
[more] $>       node {
[more] $>         id
[more] $>       }
[more] $>     }
[more] $>   }
[more] $> }
[more] $> $$);
┌────────────────────────────────────────────────────────────────┐
│                            resolve                             │
├────────────────────────────────────────────────────────────────┤
│ {"data": {"bookCollection": {"edges": [{"node": {"id": 1}}]}}} │
└────────────────────────────────────────────────────────────────┘
(1 row)

Time: 109.411 ms
david@pg_graphql=# ^D\q

(I tested the same with cargo pgrx run pg16)

@imor
Copy link
Contributor

imor commented Sep 23, 2024

Thanks for the PR @davidgomes, could you please also bump pgrx at these locations:

@olirice olirice self-requested a review September 23, 2024 14:26
@olirice olirice merged commit d79be8d into supabase:master Sep 23, 2024
4 checks passed
@olirice
Copy link
Contributor

olirice commented Sep 23, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants