Add Project Custodians #423
Conversation
|
|
||
| .. custom-card:: Will Barnes | ||
| :img_name: Will-Barnes.png | ||
| :img_name: will.png |
There was a problem hiding this comment.
These images should be better named.
There was a problem hiding this comment.
We could just grab peoples github avatar?
There was a problem hiding this comment.
Oh yeah if we can do that, we should. Less crap in this repo.
There was a problem hiding this comment.
Looking at the code, I'd say this could do:
| :img_name: will.png | |
| :img_name: https://github.com/wtbarnes.png |
in here, or, change the custom-card
https://github.com/sunpy/sunpy-sphinx-theme/blob/bd031141ca7b71245b5d886b0388ab43fbefadde/src/sunpy_sphinx_theme/cards.py#L27-L29
to:
<img class="dark-light" src="https://github.com/{node['github']}.png" alt="{node['name']}">
I'd prefer the last one and remove the need to use :img_name. Or being more conservative, add some logic to the src path that unless specified it will use github's one. Maybe not everyone wants to have their picture on github's profiles, or use a different one.
There's more to come, but I thought I would start collecting info. Only problem is I don't have everyone's GitHub handles.
Also I have run out of time for this today.