Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two bugs + cards from website #263

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Fix two bugs + cards from website #263

merged 3 commits into from
Aug 6, 2024

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Aug 5, 2024 •
edited
Loading

Fixes #256
Fixes #257

@nabobalis nabobalis changed the title WIP Fix two bugs + cards from website Aug 5, 2024
@nabobalis nabobalis mentioned this pull request Aug 5, 2024
Merged
nabobalis
nabobalis commented Aug 5, 2024
View reviewed changes
docs/conf.py Outdated Show resolved Hide resolved
@nabobalis nabobalis marked this pull request as ready for review August 6, 2024 00:17
@nabobalis nabobalis merged commit f92e892 into main Aug 6, 2024
10 checks passed
@nabobalis nabobalis deleted the fix branch August 6, 2024 21:09
@Cadair
Copy link
Member

Cadair commented Aug 7, 2024

The lack of hover-over on the card, and the fact that only the "more info" button is clickable rather than the whole card isn't ideal.

Also this has apparently broken sunpy.org?

@Cadair
Copy link
Member

Cadair commented Aug 7, 2024

Yeah, I just rebuilt sunpy.org and the build succeeded but the cards are broken.

@Cadair
Copy link
Member

Cadair commented Aug 7, 2024

It is also broken on the preview build on this PR https://output.circle-artifacts.com/output/job/5f17f6e9-6b09-4173-84d9-dccb1a3a1365/artifacts/0/.tmp/website/sunpy.org/_build/html/about/project/index.html

@nabobalis
Copy link
Contributor Author

The lack of hover-over on the card, and the fact that only the "more info" button is clickable rather than the whole card isn't ideal.

This has always been the case tho?

It is also broken on the preview build on this PR output.circle-artifacts.com/output/job/5f17f6e9-6b09-4173-84d9-dccb1a3a1365/artifacts/0/.tmp/website/sunpy.org/_build/html/about/project/index.html

Hmm, I think I need to pass the path down to the card for the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The hover colour is too much Dark theme cards hate text
2 participants
@nabobalis @Cadair