WIP: SIMDPolynomials support #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumiya11
reviewed
Jan 22, 2022
| function extract_ring(orig_polys::Vector{<:SIMDPolynomials.AbstractPolynomial}) | ||
| f = first(orig_polys) | ||
|
|
||
| nv = maximum(SIMDPolynomials.nvariables, orig_polys) |
There was a problem hiding this comment.
I am not sure if taking maximum is correct. What if the system is [x, y] ?
There was a problem hiding this comment.
Yeah, it's correct only for PackedMonomial, and not true in general.
|
Hi @YingboMa , is it true that |
|
Yes, indeed. I need to update this PR as well. |
|
Cool, I'll stay tuned ! |
|
Feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this yet. SIMDPolynomials.jl hasn't been released.