Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the width of flash alerts #615

Merged
merged 1 commit into from
May 13, 2024
Merged

Limit the width of flash alerts #615

merged 1 commit into from
May 13, 2024

Conversation

marlo-longley
Copy link
Contributor

@marlo-longley marlo-longley commented May 10, 2024

Screenshot 2024-05-10 at 16 23 54

This gets us this far on #534

As for making the "X" nicer looking, we may need to wait on this Blacklight PR in order to properly style it. I couldn't get very far with the invalid <button-tag>

@marlo-longley marlo-longley marked this pull request as ready for review May 10, 2024 22:17
Copy link
Contributor

@corylown corylown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is adding some margin between the header and the main section that we don't want when the feedback for is closed.
Screenshot 2024-05-13 at 11 08 32 AM

@marlo-longley
Copy link
Contributor Author

@corylown Thanks for spotting that. Fixed.

@corylown corylown merged commit d71dfc6 into main May 13, 2024
3 checks passed
@corylown corylown deleted the flash-dismissal branch May 13, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants