Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert design review #534

Open
corylown opened this issue Apr 16, 2024 · 2 comments
Open

Alert design review #534

corylown opened this issue Apr 16, 2024 · 2 comments
Labels
design needed question Further information is requested

Comments

@corylown
Copy link
Contributor

corylown commented Apr 16, 2024

  • Does it make sense for the alert to appear between the header and the masthead?
  • Should there be some additional padding between the header and the alert box?
  • The X to dismiss the alert looks odd. Can we add some padding and/or make it clearer it's actionable?

Image

@corylown corylown added design needed question Further information is requested labels Apr 16, 2024
@marlo-longley
Copy link
Contributor

Agree the padding and x-button could be improved, but wanted to say that the VT form is between the header and masthead, and that's specifically what I modeled this one on. Not that we have to stick to that, just some context.

Screenshot 2024-04-16 at 6 42 37 AM

@marlo-longley
Copy link
Contributor

projectblacklight/blacklight#3153 was merged for the X button in Blacklight but we won't have access to the correct markup until a new release is shipped.

This ticket is 2/3 done, just waiting on the button release so we can style it properly.

@marlo-longley marlo-longley removed their assignment May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants