Merge pull request #137 from BrumfieldLabs/quote-paths-for-shell

Quote paths to handle filenames with spaces for #136
sul-dlss · Jan 17, 2024 · 694d052 · 694d052
2 parents ae1caaf + 2b9ca62
commit 694d052
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/services/riiif/image_magick_info_extractor.rb b/app/services/riiif/image_magick_info_extractor.rb
@@ -11,7 +11,7 @@ def initialize(path)
 
     def extract
       height, width, format, channels = Riiif::CommandRunner.execute(
-        "#{external_command} -format '%h %w %m %[channels]' #{@path}[0]"
+        "#{external_command} -format '%h %w %m %[channels]' '#{@path}[0]'"
       ).split(' ')
 
       {

diff --git a/app/services/riiif/imagemagick_command_factory.rb b/app/services/riiif/imagemagick_command_factory.rb
@@ -65,7 +65,7 @@ def layer_spec
       end
 
       def input
-        " #{path}#{layer_spec}"
+        " '#{path}#{layer_spec}'"
       end
 
       # In cases where the input file has an alpha_channel but the transformation