Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a file to multiple friends: Fixes #1471 #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devAbnull
Copy link
Contributor

pop-up window with the listview of the friends online is displayed,
multiple friends cn be selected and pressing the send toolbutton sends the file to selected friends.

Note: used the PopWindow class of sugar3.graphics as implemented in commit-> sugar-toolkit-gtk3:3d61134

pop-up window with the listview of the friends online is displayed,
multiple friends cn be selected and pressing the send toolbutton sends the file to selected friends.

Note: used the PopWindow class of sugar3.graphics as implemented in commit-> sugar-toolkit-gtk3:3d61134
@samdroid-apps
Copy link
Contributor

This is a very good looking patch. Just a few comments:

  • Please put the title of the document that the user is about to send in the title. Eg "Send Cool Doc to..."
  • Please consider the empty state (no friends). You could display an empty view, like is used in the journal
  • Maybe list everybody (not just friends), but put friends first
  • Maybe put a search bar at the top of the popup, so that I can search for a friend I want. If I press enter, it should select the top friend.
  • The dialog still stays on top even after I launch another activity. Maybe it should only be on top when I am in the journal
  • Shouldn't the close button and the send button swap places?
  • "Send to" in the menu could become "Send to..."
  • Maybe clicking anywhere on a row should toggle it's checkbox
  • The toolbuttons ("Send" "Close") don't have the roll over palettes (the type of ones that say "Send" or "Close")

@i5o
Copy link
Contributor

i5o commented Dec 3, 2016

ping..?

Also, I'm not able to merge, please update the code @AbrahmAB

@quozl
Copy link
Contributor

quozl commented Dec 3, 2016

Rebasing to resolve the conflicts doesn't look hard. Two new files, and the rest of the changes are straightforward. Then respond to @samdroid-apps comments above.

MrSpideyNihal

This comment was marked as off-topic.

@quozl
Copy link
Contributor

quozl commented Dec 14, 2023

Off-topic comment hidden. Next action is to rebase the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants