Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3842 Lyric input via Phrase Maker #4016

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

therealharshit
Copy link
Contributor

I have placed print block in the phrase maker widget stack

vedio:

2024-09-27-20-14-54.mp4

please test and let me know how it's working.

@walterbender
Copy link
Member

It is a bit more complicated than that. We need to modify the print code inside of js/blocks/ExtraBlocks.js to know that when it is inMatrix to push a print block to the block list (logo.phraseMaker.addRowBlock(blk);) Then process the print blocks in the phrasemaker widget code itself the same way graphics blocks are handled.

@therealharshit
Copy link
Contributor Author

Ok I'll work on it.

@therealharshit therealharshit marked this pull request as draft October 24, 2024 18:11
@walterbender
Copy link
Member

@therealharshit
You mentioned in your chat that you made changes to the pull request but I don't see them. Did you forget to push your changes?

@therealharshit
Copy link
Contributor Author

therealharshit commented Nov 10, 2024

@therealharshit
You mentioned in your chat that you made changes to the pull request but I don't see them. Did you forget to push your changes?

The changes I made didn't work, so I haven't updated it in my PR. If you want I'll update them.

@walterbender
Copy link
Member

I cannot debug your changes if I cannot see them. So please upload them.

@therealharshit
Copy link
Contributor Author

@walterbender I have modified the flow of print block to know when it's inMatrix, and now the processing of print block in phrasemaker.js is left in which I need your help on how to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants