Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Singer issue #388

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

mohitvdx
Copy link

@mohitvdx mohitvdx commented Feb 8, 2024

PR order before #383

This is a Follow up PR from the discussion in #383.
It solves the Singer export and import issues.

Kindly review @walterbender

@mohitvdx
Copy link
Author

mohitvdx commented Feb 8, 2024

import { _state, noteValueToSeconds, _defaultSynth, _polySynth } from '@/singer';

we're importing _polySynth from the @singer file, but it's not defined there

function _getSynth(synthType: string) {
  switch (synthType) {
    case 'polysynth':
      return _polySynth;
  }
  return _defaultSynth;
}

and then we're returning it in this switch statement.
_polySynth is not defined anywhere in the project files.

How should I proceed? @walterbender

@walterbender
Copy link
Member

polysynth should be defined as one of the builtin synths in core.synthutils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants