Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link to GitHub repo #1056

Merged
merged 4 commits into from
Aug 10, 2024
Merged

feat: add link to GitHub repo #1056

merged 4 commits into from
Aug 10, 2024

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Aug 5, 2024

It uses ghub.io to link directly to the repo.

To do:

  • Add GitHub logo to
    npm: (
    <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
    <path d="M0 7.334v8h6.666v1.332H12v-1.332h12v-8zm6.666 6.664H5.334v-4H3.999v4H1.335V8.667h5.331zm4 0v1.336H8.001V8.667h5.334v5.332zm12.001 0h-1.33v-4h-1.336v4h-1.335v-4h-1.33v4h-2.671V8.667h8.002z" />
    <path d="M10.665 10H12v2.667h-1.335z" />
    </svg>
    ),

Copy link

vercel bot commented Aug 5, 2024

@fregante is attempting to deploy a commit to the Package Phobia Team on Vercel.

A member of the Team first needs to authorize it.

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 98 96">
<path d="M48.854 0C21.839 0 0 22 0 49.217c0 21.756 13.993 40.172 33.405 46.69 2.427.49 3.316-1.059 3.316-2.362 0-1.141-.08-5.052-.08-9.127-13.59 2.934-16.42-5.867-16.42-5.867-2.184-5.704-5.42-7.17-5.42-7.17-4.448-3.015.324-3.015.324-3.015 4.934.326 7.523 5.052 7.523 5.052 4.367 7.496 11.404 5.378 14.235 4.074.404-3.178 1.699-5.378 3.074-6.6-10.839-1.141-22.243-5.378-22.243-24.283 0-5.378 1.94-9.778 5.014-13.2-.485-1.222-2.184-6.275.486-13.038 0 0 4.125-1.304 13.426 5.052a46.97 46.97 0 0 1 12.214-1.63c4.125 0 8.33.571 12.213 1.63 9.302-6.356 13.427-5.052 13.427-5.052 2.67 6.763.97 11.816.485 13.038 3.155 3.422 5.015 7.822 5.015 13.2 0 18.905-11.404 23.06-22.324 24.283 1.78 1.548 3.316 4.481 3.316 9.126 0 6.6-.08 11.897-.08 13.526 0 1.304.89 2.853 3.316 2.364 19.412-6.52 33.405-24.935 33.405-46.691C97.707 22 75.788 0 48.854 0z"/>
</svg>
),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled from https://github.com/logos and cleaned of extra attributes

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
packagephobia ✅ Ready (Inspect) Visit Preview Aug 10, 2024 7:48pm

Copy link
Owner

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I tried visiting “satori” and it fails with 404.

I’m guessing that you’ll need to pass the version too, not just the name.

@fregante
Copy link
Contributor Author

fregante commented Aug 8, 2024

It seems to be due to a lack of updates:

Does this component have access to the package.json? If so, it could compute the repo URL directly

@fregante
Copy link
Contributor Author

fregante commented Aug 8, 2024

Fixed 👍

Copy link
Owner

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 🥇

@styfle styfle enabled auto-merge (squash) August 10, 2024 19:47
@styfle styfle disabled auto-merge August 10, 2024 19:47
@styfle styfle changed the title Add link to GitHub repo feat: add link to GitHub repo Aug 10, 2024
@styfle styfle enabled auto-merge (squash) August 10, 2024 19:48
@styfle styfle merged commit ac730f6 into styfle:main Aug 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to GitHub repo
2 participants