Promote experimental changes #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing close handler * WIP: schema changes for tracking read history * WIP: lots of refactoring for read sessions * WIP: refactor UI areas wrt progress * fix awkwardness wrt PUT media progress
* Create basic resolution analysis job * Modified schema and restructured analysis task * Complete task and prisma storage of image dimensions * Make page dimensions accessible from server * Improve compression of resolution encoding * Correct error in PageResolutions creation * Use consistent naming for page dimensions * Fix linking in doc comment for subtasks. * Code cleanup Change into_image_format into a TryFrom<ContentType> for image::ImageFormat impl; Add doc comment to explain page_dimension model. * Don't use subtasks in AnalyzeMediaTask::FullAnalysis * Correct doc comments * Fix misnamed variable * Make codegen export PageDimension and PageDimensionsEntity * Update apps/server/src/routers/api/v1/media.rs Co-authored-by: Aaron Leopold <[email protected]> * Update core/src/filesystem/media/analyze_media_job/mod.rs Co-authored-by: Aaron Leopold <[email protected]> * Address review comments * Index per-page dimensions from 1 * 🚨 Fix cargo build and clipy lints
The changes which fix the issue relocated to another file #354
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR brings in all of the developed, experimental features to develop