⬇️ Downgrade zip crate to 1.1.3 (#435)

* ⬇️ Downgrade `zip` crate to `1.1.3` Relates to #427 * fix test
stumpapp · Sep 6, 2024 · fe35819 · fe35819
1 parent ceb2aa1
commit fe35819
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 176 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -45,7 +45,8 @@ uuid = "1.10.0"
 walkdir = "2.5.0"
 webp = "0.3.0"
 xml-rs = "0.8.21" # XML reader/writer
-zip = "2.2.0"
+# Note: We need to keep this downgraded for the time being. See https://github.com/stumpapp/stump/issues/427#issuecomment-2332857700
+zip = { version = "=1.1.3", features = ["deflate"], default-features = false }
 
 [dev-dependencies]
 temp-env = "0.3.6"

diff --git a/core/src/filesystem/archive.rs b/core/src/filesystem/archive.rs
@@ -17,7 +17,7 @@ pub(crate) fn zip_dir(
 
 	let mut zip_writer = zip::ZipWriter::new(zip_file);
 
-	let options: FileOptions<'_, ()> = FileOptions::default()
+	let options: FileOptions<()> = FileOptions::default()
 		.compression_method(CompressionMethod::Stored)
 		.unix_permissions(0o755);
 
@@ -110,7 +110,7 @@ mod tests {
 		assert_eq!(zip_archive.len(), 1);
 
 		let mut file = zip_archive.by_index(0).unwrap();
-		assert_eq!(file.name(), "file.txt");
+		assert_eq!(file.name(), "/file.txt");
 
 		let mut contents = String::new();
 		file.read_to_string(&mut contents).unwrap();