Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames the OrderLegCollection class to better represent order legs #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vphilipnyc
Copy link
Contributor

Leaves JSON property in place. Feel free to not merge this PR if this will cause serialization issues.

@studerw
Copy link
Owner

studerw commented Jul 29, 2020

Hey @vphilipnyc , have you actually checked this with any responses that have multiple 'legs'? I like your name better than using the verbose OrderLegCollection - that was generated based on the schema, though, and unless we annotate the pojo fields with an explicit Jackson name it won't auto deserialize it if the JSON itself uses 'OrderLegCollection' as the wrapper.

Unfortunately, I haven't tested many complex orders (I don't understand them :/) so I'm not sure I've had any JSON being returned with a OrderLegCollection that's filled in.

@vphilipnyc
Copy link
Contributor Author

@studerw , I am able to iterate through orderLegs with no issue, though I must admit that my actual orders only seem to have one leg at the moment. On my Thymeleaf front end, it looks like:

                                            <th:block th:each="orderLeg: ${order.orderLegs}">
                                                <p th:text="${orderLeg?.instrument?.symbol} + ': ' +${orderLeg?.instruction} + ', Qty: '+${#numbers.formatDecimal(order?.quantity, 0, 0)}">[description]</p>
                                            </th:block>

And it prints the values just fine. I just haven't placed any orders with multiple legs recently, but can look out for it if you'd prefer to hold off merging this PR. Jackson will just use the name you specify though.

Aside, I also use the simpler:

@JsonProperty("legId")
String id;

Since the class is called OrderLeg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants