Add a metric for counting metrics received. #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalindo-stripe
previously approved these changes
Aug 29, 2022
arnavdugar-stripe
force-pushed
the
arnavdugar/source
branch
from
0a2ac07
to
920572f
Compare
rma-stripe
requested changes
Sep 2, 2022
| statsd.WithAggregationInterval(conf.Interval), | ||
| statsd.WithChannelMode(), | ||
| statsd.WithChannelModeBufferSize(64), | ||
| statsd.WithClientSideAggregation(), |
There was a problem hiding this comment.
Turning on client side aggregation appears to be breaking tests
arnavdugar-stripe
force-pushed
the
arnavdugar/source
branch
from
920572f
to
fe806cd
Compare
arnavdugar-stripe
force-pushed
the
arnavdugar/source
branch
from
fe806cd
to
158d207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a metric
veneur.source.metric_countfor counting metrics received.This metric is guarded by the
EnableSourceMetricCountflag.