Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throttle and fault tags to X-Ray #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gphat
Copy link
Contributor

@gphat gphat commented Aug 22, 2019

Summary

Adds throttle and fault capability to the X-Ray sink.

Motivation

X-Ray has three different error-like attributes but the conversion from SSFSpan to XRaySegment has nothing to use for these fields.

This adds two new config options that, when the tags are present, sets these fields.

Test plan

Added tests.

@gphat gphat changed the title Add throttle and fault tags to XRay Add throttle and fault tags to X-Ray Aug 22, 2019
@stripe-ci
Copy link

Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requests

cc @stripe/observability
@stripe/observability-stripe

@gphat
Copy link
Contributor Author

gphat commented Aug 24, 2019

(These tests pass locally for me, fwiw. I can't trigger a re-run to test for flakes.)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants