Upgrade datadog to 2.2.0 for UDS bug fixes #722
Conversation
Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requestscc @stripe/observability |
|
Ah, sorry for missing this PR for so long! The change looks good, but can you rebase onto master? |
prudhvi
force-pushed
the
prudhvi.upgrade_datadog
branch
from
78c8a7c to
a613928
Compare
|
@asf-stripe Thanks, rebased with latest master |
asf-stripe
force-pushed
the
prudhvi.upgrade_datadog
branch
from
7f7be99 to
a613928
Compare
|
So we had a small misconfiguration in our CI setup which required me to push an empty commit (now rebased away again) so that tests actually get run - now it looks like tests are properly failing; can you check them out? |
| @@ -320,7 +361,7 @@ func (c *Client) sendMsg(msg string) error { | |||
| // send handles sampling and sends the message over UDP. It also adds global namespace prefixes and tags. | |||
| func (c *Client) send(name string, value interface{}, suffix []byte, tags []string, rate float64) error { | |||
| if c == nil { | |||
| return nil | |||
| return fmt.Errorf("Client is nil") | |||
There was a problem hiding this comment.
The test failure seems to be related to this change. We weren't expecting a nil statsd client to raise, but maybe we ought to? I'm not sure.
There was a problem hiding this comment.
Made DataDog/datadog-go#90 to fix this. Once it's merged & pulled in, we'll have to adjust the test case to check for the error constant.
There was a problem hiding this comment.
Ah, thanks should have run locally before opening. Also TIL, go test ./... to run all tests.
Do you want me to change the constraint in gopkg.toml to specific sha and fix tests or should we actually wait for new release version of datadog client.
There was a problem hiding this comment.
I think it should be fine to update to the git version, especially if the bugfixes you are pulling in are blocking you!
Note that the test will need an update also, to validate that ErrNoClient is returned in the case of an empty client.
prudhvi
force-pushed
the
prudhvi.upgrade_datadog
branch
from
16d6a51 to
c0f2e20
Compare
|
|
Summary
Upgrading the datadog client dependency to latest so that contains some features and bug fixes for Unix domain socket support.
https://github.com/DataDog/datadog-go/blob/master/CHANGELOG.md
Not adding a new CHANGELOG.md entry as it already contains my previous bump for ongoing version.
Motivation
To use the UDS client support with latest improvements and bug fixes.