Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested lists #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix nested lists #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,19 @@

## Incompatible changes
* These deprecated configuration keys are no longer supported and will cause an error on startup if used in a veneur config file:
** `api_hostname` - replaced in 1.5.0 by `datadog_api_hostname`
** `key` - replaced in 1.5.0 by `datadog_api_key`
** `trace_address` - replaced in 1.7.0 by `ssf_listen_addresses`
** `trace_api_address` - replaced in 1.5.0 by `datadog_trace_api_address`
** `ssf_address` - replaced in 1.7.0 by `ssf_listen_addresses`
** `tcp_address` and `udp_address` - replaced in 1.7.0 by `statsd_listen_addresses`
* `api_hostname` - replaced in 1.5.0 by `datadog_api_hostname`
* `key` - replaced in 1.5.0 by `datadog_api_key`
* `trace_address` - replaced in 1.7.0 by `ssf_listen_addresses`
* `trace_api_address` - replaced in 1.5.0 by `datadog_trace_api_address`
* `ssf_address` - replaced in 1.7.0 by `ssf_listen_addresses`
* `tcp_address` and `udp_address` - replaced in 1.7.0 by `statsd_listen_addresses`
* These metrics have changed names:
** Datadog, MetricExtraction, and SignalFx sinks now emit `veneur.sink.metric_flush_total_duration_ns` for metric flush duration and tag it with `sink`
** Datadog, Kafka, MetricExtraction, and SignalFx sinks now emits `sink.metrics_flushed_total` for metric flush counts and tag it with `sink`
** Datadog and LightStep sinks now emit `veneur.sink.span_flush_total_duration_ns` for span flush duration and tag it with `sink`
** Datadog, Kafka, MetricExtraction, and LightStep sinks now emit `sink.spans_flushed_total` for metric flush counts and tag it with `sink`
* Datadog, MetricExtraction, and SignalFx sinks now emit `veneur.sink.metric_flush_total_duration_ns` for metric flush duration and tag it with `sink`
* Datadog, Kafka, MetricExtraction, and SignalFx sinks now emits `sink.metrics_flushed_total` for metric flush counts and tag it with `sink`
* Datadog and LightStep sinks now emit `veneur.sink.span_flush_total_duration_ns` for span flush duration and tag it with `sink`
* Datadog, Kafka, MetricExtraction, and LightStep sinks now emit `sink.spans_flushed_total` for metric flush counts and tag it with `sink`
* Veneur's internal metrics are no longer tagged with `veneurlocalonly`. This means that percentile metrics (such as timers) will now be aggregated globally.


## Added
* `veneur-emit` now infers parent and trace IDs from the environment (using the variables `VENEUR_EMIT_TRACE_ID` and `VENEUR_EMIT_PARENT_SPAN_ID`) and sets these environment variables from its `-trace_id` and `parent_span_id` when timing commands, allowing for convenient construction of trace trees if traced programs call `veneur-emit` themselves. Thanks, [antifuchs](https://github.com/antifuchs)
* The Kafka sink for spans can now sample spans (at a rate determined by `kafka_span_sample_rate_percent`) based off of traceIDs (by default) or a tag's values (configurable via `kafka_span_sample_tag`) to consistently sample spans related to each other. Thanks, [rhwlo](https://github.com/rhwlo)!
Expand Down