Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to Datadog spans #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gphat
Copy link
Contributor

@gphat gphat commented Jul 22, 2017

Summary

Adds metrics to outgoing Datadog spans.

Motivation

SSF's spans can contain metrics and so can Datadog's! The code, however, doesn't add them to the outgoing span. Now it does!

Test plan

No tests yet — mainly because I'm not sure how to serialize a protobuf into a file to update the fixture. Will ping @aditya-stripe. :)

Verified locally however:

screenshot 2017-07-22 10 07 56

@gphat gphat changed the title Add metrics to Datadog spans. Add metrics to Datadog spans Jul 22, 2017
@stripe-ci
Copy link

Gerald Rule: Copy Observability on Veneur and Unilog pull requests

cc @stripe/observability
cc @stripe/observability-stripe

@asf-stripe
Copy link
Contributor

@cory - this is failing tests and needs a rebase; should we bump this from 1.7?

@gphat
Copy link
Contributor Author

gphat commented Oct 5, 2017 via email

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants