Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

veneur-prometheus bugfix: Specifying multiple tags/labels with -a causes sporadic incorrect metric emission #1052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Feb 28, 2023

  1. Bugfix: Specifying multiple tags/labels with -a causes sporadic incor…

    …rect metric calculations
    
    This fixes a bug that caused diff calculations to sporadically break when multiple labels
    were added via the -a flag.  Labels were stored as key/values in a map and returned in a potentially different order
    each time since map iteration order is random.  This caused the translator to emit the cumulative value instead of
    the diffed value, because it would seem as though the metric was new when in fact it had been previously cached
    with a different label ordering.  For example, the translator might look for "counter-key2:value2-key1:value1" when
    it had been previously cached as "counter-key1:value1-key2:value2"
    dmarriner committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    fd22d78 View commit details
    Browse the repository at this point in the history