Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test flakiness due to resource contention and timing #1017

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

andrewa-stripe
Copy link
Contributor

Summary

  • Increase timeouts for some tests (go has timeouts as test runner first-class which can be used when we need fast)
  • Use assert.Eventually (this would be better than the timeouts, usually, as it will enable the test to pass as soon as it can, without trading off latency OR flakiness)

Motivation

CI builds break a lot
image

Test plan

  • run tests

Rollout/monitoring/revert plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants