Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update static methods for delete/list on BankAccount/Card to throw NotImplementedError #1420

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

ramya-stripe
Copy link
Contributor

Changelog

  • The below methods have been throwing InvalidRequestError because the urls used to make the requests have been buggy. Updating them to throw NotImplementedError instead just like their counterparts for update & retrieve because they cannot be implemented without the parent id.
Methods affected Use these instead in the context of payment method Use these in the context of external accounts
Stripe:: BankAccount.delete Stripe::Customer.delete_source Stripe::Account.delete_external_account
Stripe:: BankAccount.list Stripe::Customer.list_sources Stripe::Customer.list_external_accounts
Stripe:: Card.delete Stripe::Customer.delete_source Stripe::Account.delete_external_account
Stripe:: Card.list Stripe::Customer.list_sources Stripe::Customer.list_external_accounts

@ramya-stripe ramya-stripe merged commit fa2baeb into master Jun 27, 2024
14 checks passed
@ramya-stripe ramya-stripe deleted the ramya/ruby-bankaccount-card branch June 27, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants