Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IdentityVerification Example to allow for reusing VerificationSessions #4427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aywang-stripe
Copy link
Contributor

Summary

Updates Identity Verification Example app to allow for reusing VerificationSessions. Reusing VerificationSessions is a common pattern for Stripe Identity users.

Motivation

Allow for better testing of all of the possible integration paths that an integrator may implement.

Testing

Tested in simulator to validate new behavior

Screen.Recording.2024-12-23.at.2.39.11.PM.mov

Changelog

  • [Added] Updates example app to allow reusing VerificationSessions.

Copy link

⚠️ Public API changes detected:

StripePaymentSheet

- case embeddedPaymentElementAlreadyConfirmedIntent

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Copy link

emerge-tools bot commented Dec 23, 2024

6 builds decreased size

Name Version Download Change Install Change Approval
StripeSize
com.stripe.StripeSize
1.0 (1) 2.1 MB ⬇️ 33.5 kB (-1.57%) 6.9 MB ⬇️ 74.3 kB (-1.07%) N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 449.7 kB ⬇️ 30.0 kB (-6.26%) 1.6 MB ⬇️ 77.9 kB (-4.8%) N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.3 MB ⬇️ 42.0 kB (-3.04%) 4.4 MB ⬇️ 107.4 kB (-2.42%) N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.2 MB ⬇️ 28.3 kB (-2.36%) 4.1 MB ⬇️ 77.3 kB (-1.86%) N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬇️ 32.2 kB (-1.65%) 6.4 MB ⬇️ 73.6 kB (-1.15%) N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.7 MB ⬇️ 40.0 kB (-1.07%) 11.0 MB ⬇️ 140.2 kB (-1.27%) N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 74.3 kB (-1.07%)
Total download size change: ⬇️ 33.5 kB (-1.57%)

Largest size changes

Item Install Size Change
🗑 StripeCore.StripeAttest ⬇️ -6.5 kB
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.1 kB
DYLD.Exports ⬇️ -3.5 kB
StripeCore.UnknownFieldsDecodable.applyUnknownFieldDecodingTransf... ⬇️ -3.0 kB
🗑 StripeCore.StripeChallengeResponse ⬇️ -2.7 kB
View Treemap

Image of diff

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 77.9 kB (-4.8%)
Total download size change: ⬇️ 30.0 kB (-6.26%)

Largest size changes

Item Install Size Change
🗑 StripeCore.StripeAttest ⬇️ -6.6 kB
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.1 kB
StripeCore.UnknownFieldsDecodable.applyUnknownFieldDecodingTransf... ⬇️ -3.0 kB
DYLD.Exports ⬇️ -3.0 kB
🗑 StripeCore.StripeChallengeResponse ⬇️ -2.7 kB
View Treemap

Image of diff

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 107.4 kB (-2.42%)
Total download size change: ⬇️ 42.0 kB (-3.04%)

Largest size changes

Item Install Size Change
🗑 StripeCore.StripeAttest ⬇️ -6.5 kB
🗑 StripeFinancialConnections.FinancialConnectionsWebFlowViewControl... ⬇️ -4.3 kB
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.1 kB
DYLD.Exports ⬇️ -4.0 kB
📝 StripeFinancialConnections.FinancialConnectionsWebFlowViewControl... ⬆️ 3.9 kB
View Treemap

Image of diff

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 77.3 kB (-1.86%)
Total download size change: ⬇️ 28.3 kB (-2.36%)

Largest size changes

Item Install Size Change
🗑 StripeCore.StripeAttest ⬇️ -6.6 kB
DYLD.Exports ⬇️ -4.6 kB
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.1 kB
StripeCore.UnknownFieldsDecodable.applyUnknownFieldDecodingTransf... ⬇️ -3.0 kB
🗑 StripeCore.StripeChallengeResponse ⬇️ -2.7 kB
View Treemap

Image of diff

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 73.6 kB (-1.15%)
Total download size change: ⬇️ 32.2 kB (-1.65%)

Largest size changes

Item Install Size Change
🗑 StripeCore.StripeAttest ⬇️ -6.5 kB
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.1 kB
DYLD.Exports ⬇️ -3.4 kB
StripeCore.UnknownFieldsDecodable.applyUnknownFieldDecodingTransf... ⬇️ -3.0 kB
🗑 StripeCore.StripeChallengeResponse ⬇️ -2.7 kB
View Treemap

Image of diff

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 140.2 kB (-1.27%)
Total download size change: ⬇️ 40.0 kB (-1.07%)

Largest size changes

Item Install Size Change
📝 [email protected] ⬆️ 14.5 kB
🗑 StripePaymentSheet.VerticalPaymentMethodListViewController.init(i... ⬇️ -9.2 kB
🗑 StripePaymentSheet.RowButton.init(appearance,originalCornerRadius... ⬇️ -9.0 kB
📝 [email protected] ⬆️ 8.9 kB
📝 StripePaymentSheet.VerticalPaymentMethodListViewController.init(i... ⬆️ 8.7 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant