-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update promo in MPE after bank flow #4370
Draft
tillh-stripe
wants to merge
8
commits into
tillh/ibp-incentives-fetch-available-incentives
Choose a base branch
from
tillh/ibp-incentives-update-mpe-after-flow
base: tillh/ibp-incentives-fetch-available-incentives
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update promo in MPE after bank flow #4370
tillh-stripe
wants to merge
8
commits into
tillh/ibp-incentives-fetch-available-incentives
from
tillh/ibp-incentives-update-mpe-after-flow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 New dead code detected in this PR: StripeAttestBackend.swift:24 warning: Parameter 'appId' is unused
StripeAttestBackend.swift:24 warning: Parameter 'deviceId' is unused
StripeAttestBackend.swift:24 warning: Parameter 'keyId' is unused
StripeAttestBackend.swift:20 warning: Parameter 'attestation' is unused
StripeAttestBackend.swift:14 warning: Property 'apiClient' is assigned, but never used
SavedPaymentMethodRowButton.swift:9 warning: Imported module 'StripeCore' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
Aligns the last-4 look across payment method types.
- Rename `theme` to `appearance` - Add snapshot with long bank name - Make `text` nullable
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
from
December 18, 2024 20:16
26f0c61
to
d495949
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
from
December 20, 2024 14:31
5ad3d19
to
b83e20a
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-update-mpe-after-flow
branch
2 times, most recently
from
December 20, 2024 16:24
685579c
to
2ed15ab
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-update-mpe-after-flow
branch
from
December 20, 2024 19:43
2ed15ab
to
242910b
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
from
December 20, 2024 19:44
b83e20a
to
e564e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog