Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update promo in MPE after bank flow #4370

Draft
wants to merge 8 commits into
base: tillh/ibp-incentives-fetch-available-incentives
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

Copy link

github-actions bot commented Dec 18, 2024

🚨 New dead code detected in this PR:

StripeAttestBackend.swift:24 warning: Parameter 'appId' is unused
StripeAttestBackend.swift:24 warning: Parameter 'deviceId' is unused
StripeAttestBackend.swift:24 warning: Parameter 'keyId' is unused
StripeAttestBackend.swift:20 warning: Parameter 'attestation' is unused
StripeAttestBackend.swift:14 warning: Property 'apiClient' is assigned, but never used
SavedPaymentMethodRowButton.swift:9 warning: Imported module 'StripeCore' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

Aligns the last-4 look across payment method types.
- Rename `theme` to `appearance`
- Add snapshot with long bank name
- Make `text` nullable
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-fetch-available-incentives branch from 26f0c61 to d495949 Compare December 18, 2024 20:16
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-fetch-available-incentives branch from 5ad3d19 to b83e20a Compare December 20, 2024 14:31
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-update-mpe-after-flow branch 2 times, most recently from 685579c to 2ed15ab Compare December 20, 2024 16:24
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-update-mpe-after-flow branch from 2ed15ab to 242910b Compare December 20, 2024 19:43
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-fetch-available-incentives branch from b83e20a to e564e9e Compare December 20, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant