-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New manage card screen with cbc update and remove #4251
base: master
Are you sure you want to change the base?
Conversation
Card details cannot be changed., Manage card If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link. |
|
Name | Version | Download | Change | Install | Change | Approval |
---|---|---|---|---|---|---|
StripeSize com.stripe.StripeSize |
1.0 (1) | 2.1 MB | ⬇️ 1.2 kB (-0.06%) | 6.9 MB | ⬆️ 7.2 kB (0.11%) | N/A |
StripeApplePaySize com.stripe.StripeApplePaySize |
1.0 (1) | 449.0 kB | ⬆️ 72 B (0.02%) | 1.6 MB | ⬆️ 144 B | N/A |
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize |
1.0 (1) | 1.3 MB | ⬆️ 1.8 kB (0.13%) | 4.4 MB | ⬆️ 5.3 kB (0.12%) | N/A |
StripePaymentsSize com.stripe.StripePaymentsSize |
1.0 (1) | 1.2 MB | ⬆️ 467 B (0.04%) | 4.1 MB | ⬆️ 144 B | N/A |
StripePaymentsUISize com.stripe.StripePaymentsUISize |
1.0 (1) | 1.9 MB | ⬆️ 4.0 kB (0.21%) | 6.3 MB | ⬆️ 6.8 kB (0.11%) | N/A |
StripePaymentSheetSize com.stripe.StripePaymentSheetSize |
1.0 (1) | 3.7 MB | ⬆️ 10.3 kB (0.28%) | 10.9 MB | ⬆️ 37.8 kB (0.35%) | N/A |
StripeSize 1.0 (1)
com.stripe.StripeSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 7.2 kB (0.11%)
Total download size change: ⬇️ 1.2 kB (-0.06%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i... | ⬆️ 1.5 kB |
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa... | ⬆️ 632 B |
DYLD.Exports | ⬆️ 552 B |
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla... | ⬇️ -552 B |
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 72 B (0.02%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 144 B |
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 5.3 kB (0.12%)
Total download size change: ⬆️ 1.8 kB (0.13%)
Largest size changes
Item | Install Size Change |
---|---|
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
Other | ⬆️ 4.2 kB |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 467 B (0.04%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 144 B |
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 6.8 kB (0.11%)
Total download size change: ⬆️ 4.0 kB (0.21%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i... | ⬆️ 1.5 kB |
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa... | ⬆️ 632 B |
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla... | ⬇️ -552 B |
DYLD.Exports | ⬆️ 528 B |
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 37.8 kB (0.35%)
Total download size change: ⬆️ 10.3 kB (0.28%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentSheet.UpdatePaymentMethodViewController.cardBrandDro... | ⬆️ 2.4 kB |
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i... | ⬆️ 1.5 kB |
📝 StripePaymentSheet.UpdatePaymentMethodViewController.Objc Metadat... | ⬆️ 1.4 kB |
📝 StripePaymentSheet.UpdatePaymentMethodViewController.deleteButton | ⬆️ 1.2 kB |
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
🛸 Powered by Emerge Tools
1 similar comment
|
Name | Version | Download | Change | Install | Change | Approval |
---|---|---|---|---|---|---|
StripeSize com.stripe.StripeSize |
1.0 (1) | 2.1 MB | ⬇️ 1.2 kB (-0.06%) | 6.9 MB | ⬆️ 7.2 kB (0.11%) | N/A |
StripeApplePaySize com.stripe.StripeApplePaySize |
1.0 (1) | 449.0 kB | ⬆️ 72 B (0.02%) | 1.6 MB | ⬆️ 144 B | N/A |
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize |
1.0 (1) | 1.3 MB | ⬆️ 1.8 kB (0.13%) | 4.4 MB | ⬆️ 5.3 kB (0.12%) | N/A |
StripePaymentsSize com.stripe.StripePaymentsSize |
1.0 (1) | 1.2 MB | ⬆️ 467 B (0.04%) | 4.1 MB | ⬆️ 144 B | N/A |
StripePaymentsUISize com.stripe.StripePaymentsUISize |
1.0 (1) | 1.9 MB | ⬆️ 4.0 kB (0.21%) | 6.3 MB | ⬆️ 6.8 kB (0.11%) | N/A |
StripePaymentSheetSize com.stripe.StripePaymentSheetSize |
1.0 (1) | 3.7 MB | ⬆️ 10.3 kB (0.28%) | 10.9 MB | ⬆️ 37.8 kB (0.35%) | N/A |
StripeSize 1.0 (1)
com.stripe.StripeSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 7.2 kB (0.11%)
Total download size change: ⬇️ 1.2 kB (-0.06%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i... | ⬆️ 1.5 kB |
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa... | ⬆️ 632 B |
DYLD.Exports | ⬆️ 552 B |
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla... | ⬇️ -552 B |
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 72 B (0.02%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 144 B |
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 5.3 kB (0.12%)
Total download size change: ⬆️ 1.8 kB (0.13%)
Largest size changes
Item | Install Size Change |
---|---|
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
Other | ⬆️ 4.2 kB |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 144 B
Total download size change: ⬆️ 467 B (0.04%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 144 B |
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 6.8 kB (0.11%)
Total download size change: ⬆️ 4.0 kB (0.21%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i... | ⬆️ 1.5 kB |
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
📝 StripePaymentsUI.DropdownFieldElement.makeCardBrandDropdownWithLa... | ⬆️ 632 B |
StripePaymentsUI.DropdownFieldElement.items(from,theme,includePla... | ⬇️ -552 B |
DYLD.Exports | ⬆️ 528 B |
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 37.8 kB (0.35%)
Total download size change: ⬆️ 10.3 kB (0.28%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentSheet.UpdatePaymentMethodViewController.cardBrandDro... | ⬆️ 2.4 kB |
📝 StripePaymentsUI.DropdownFieldElement.itemsWithLabel(from,theme,i... | ⬆️ 1.5 kB |
📝 StripePaymentSheet.UpdatePaymentMethodViewController.Objc Metadat... | ⬆️ 1.4 kB |
📝 StripePaymentSheet.UpdatePaymentMethodViewController.deleteButton | ⬆️ 1.2 kB |
StripeUICore.PickerFieldView.displayText.setter | ⬆️ 1.1 kB |
🛸 Powered by Emerge Tools
🚨 New dead code detected in this PR: UpdatePaymentMethodViewController.swift:188 warning: Initializer 'init(paymentMethod:removeSavedPaymentMethodMessage:appearance:hostedSurface:canEditCard:canRemoveCard:isTestMode:cardBrandFilter:)' is unused
UpdatePaymentMethodViewController.swift:307 warning: Parameter 'sheetNavigationBar' is unused
STPCardBrand+PaymentsUI.swift:43 warning: Parameter 'maxWidth' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
Summary
New screen for managing payment methods. Only for card right now. Cbc update or remove
Builds on branch joyceqin-MOBILESDK-2661
Link to Figma: https://www.figma.com/design/ysEUcRWOfdEH4C0jBA0EkH/MPE-LPM-Visibility-%26-Vertical-Mode-Rollout?node-id=9266-174142&node-type=frame&t=6jEm7yaKldiNM3E9-0
Motivation
Sync default pms project
MOBILESDK-2662
Testing
Snapshot test
Changelog