Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case for 1 PM when editing #3736

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Jul 1, 2024

Summary

  • Don't use plural when only 1 PM available.
  • Not waiting for translations as this is not GA'd.

Motivation

  • Quality review

Testing

  • Manual

Changelog

N/A

Copy link

github-actions bot commented Jul 1, 2024

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Manage payment method

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

@porter-stripe porter-stripe marked this pull request as ready for review July 1, 2024 20:55
@porter-stripe porter-stripe requested review from a team as code owners July 1, 2024 20:55
@porter-stripe porter-stripe merged commit 5a4c1ef into master Jul 1, 2024
5 checks passed
@porter-stripe porter-stripe deleted the porter/copy-edge-case-vert branch July 1, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants