Fixed an issue where certain cobranded cards showed a generic card ic… #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
force-pushed
the
yuki/fix-display-brand-image
branch
from
a483ef8
to
ab4dc2e
Compare
porter-stripe
previously approved these changes
Jun 28, 2024
| @@ -55,14 +55,20 @@ extension PaymentOption { | |||
| } | |||
|
|
|||
| extension STPPaymentMethod { | |||
| /// Returns the first non-unknown card brand, prioritizing the card's preferred network brand > display brand > brand | |||
| func calculateCardBrandToDisplay() -> STPCardBrand { | |||
…on instead of using the other card brand
yuki-stripe
force-pushed
the
yuki/fix-display-brand-image
branch
from
ab4dc2e
to
ef587fc
Compare
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
porter-stripe
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on instead of using the other card brand
Summary
We only use "preferred" card brand for icon. If it's unknown, we should fall back to the brand. This appears to match what Stripe.js does.
Example:
4000050360000001preferred brand is eftpos_australia and brand is visa. We show an unknown icon but stripe.js shows a visa icon.Motivation
https://docs.google.com/document/d/1tRLvYH4_UzRGevJuP15gU4SlU5zt9_pJBZtiOSMxy6A/edit search "AU Saved Payment Icon"
Testing
Manually tested, added unit test.
Changelog
See changelog