Egeniesse/add sunbit #3724
Egeniesse/add sunbit #3724
Conversation
StripePayments+ get
+ }
+ @objc public var sunbit: StripePayments.STPPaymentMethodSunbit? {
+ case sunbit
+ @objc public var sunbit: StripePayments.STPPaymentMethodSunbitParams?
+ @objc convenience public init(sunbit: StripePayments.STPPaymentMethodSunbitParams, billingDetails: StripePayments.STPPaymentMethodBillingDetails?, metadata: [Swift.String : Swift.String]?)
+ @objc public var allResponseFields: [Swift.AnyHashable : Any] {
+ get
+ }
+ @objc override dynamic public var description: Swift.String {
+ @objc get
+ }
+ @objc public class func decodedObject(fromAPIResponse response: [Swift.AnyHashable : Any]?) -> Self?
+ @objc deinit
+ @objc public var additionalAPIParameters: [Swift.AnyHashable : Any]
+ @objc public class func rootObjectName() -> Swift.String?
+ @objc public class func propertyNamesToFormFieldNamesMapping() -> [Swift.String : Swift.String]
+ @objc override dynamic public init()
+ @objc deinitIf you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
egeniesse-stripe
force-pushed
the
egeniesse/add-sunbit
branch
6 times, most recently
from
a18fbac
to
89018fb
Compare
egeniesse-stripe
force-pushed
the
egeniesse/add-sunbit
branch
from
89018fb
to
152bb34
Compare
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ### Payments | |||
| * [Fixed] An issue where the correct card brand was not being displayed for card brand choice in STPPaymentOptionsViewController and STPPaymentContext. | |||
| * [Added] Support for Sunbit bindings. | |||
There was a problem hiding this comment.
Should we add (Private Beta) too or no
|
|
||
| func testLpm_Sunbit_AutomaticFields() throws { | ||
| var settings = PaymentSheetTestPlaygroundSettings.defaultValues() | ||
| settings.customerMode = .guest | ||
| settings.currency = .usd | ||
| settings.merchantCountryCode = .US | ||
| settings.applePayEnabled = .off | ||
| settings.apmsEnabled = .off | ||
| settings.linkEnabled = .off | ||
| settings.attachDefaults = .off | ||
| settings.collectName = .automatic | ||
| settings.collectEmail = .automatic | ||
| settings.collectPhone = .automatic | ||
| settings.collectAddress = .automatic | ||
| loadPlayground( | ||
| app, | ||
| settings | ||
| ) | ||
|
|
||
| checkoutButton.tap() | ||
|
|
||
| let cell = try XCTUnwrap(scroll(collectionView: app.collectionViews.firstMatch, toFindCellWithId: "sunbit")) | ||
| cell.tap() | ||
|
|
||
| XCTAssertFalse(emailField.exists) | ||
| XCTAssertFalse(fullNameField.exists) | ||
| XCTAssertFalse(phoneField.exists) | ||
| XCTAssertFalse(phoneField.exists) | ||
| XCTAssertFalse(billingAddressField.exists) | ||
| XCTAssertFalse(app.textFields["Country"].exists) | ||
| XCTAssertFalse(line1Field.exists) | ||
| XCTAssertFalse(line2Field.exists) | ||
| XCTAssertFalse(cityField.exists) | ||
| XCTAssertFalse(stateField.exists) | ||
| XCTAssertFalse(zipField.exists) | ||
|
|
||
| // Just check the button is enabled | ||
| var payButton: XCUIElement { app.buttons["Pay $50.99"] } | ||
| XCTAssertTrue(payButton.isEnabled) | ||
| } |
There was a problem hiding this comment.
Let's remove these, not sure why we started this test pattern. There's nothing sunbit-specific about automatic billing detail collection, we can probably craft good unit tests instead of all of these UI tests (cc @davidme-stripe ).
| func testSunbitPaymentMethod() throws { | ||
| var settings = PaymentSheetTestPlaygroundSettings.defaultValues() | ||
| settings.currency = .usd | ||
| settings.merchantCountryCode = .US | ||
| settings.customerMode = .new | ||
| settings.apmsEnabled = .off | ||
| loadPlayground(app, settings) | ||
| app.buttons["Present PaymentSheet"].tap() | ||
| let payButton = app.buttons["Pay $50.99"] | ||
|
|
||
| // Select Sunbit | ||
| guard let sunbit = scroll(collectionView: app.collectionViews.firstMatch, toFindCellWithId: "Sunbit") else { | ||
| XCTFail() | ||
| return | ||
| } | ||
| sunbit.tap() | ||
|
|
||
| XCTAssertTrue(payButton.isEnabled) | ||
|
|
||
| // Attempt payment, should succeed | ||
| payButton.tap() | ||
| } | ||
|
|
There was a problem hiding this comment.
I understand you're just copying the existing test pattern here, but I think these tests need to complete payment or they're not testing enough to be useful. You can leave it as-is in this PR, I can't find an example to copy that completes the payment.
cc @davidme-stripe I think we should make all of these complete payment, there's nothing else that can test this final part of the checkout flow of 'next action handled -> paymenthandler completes payment'.
| XCTAssertNil(error) | ||
| XCTAssertNotNil(paymentMethod, "Payment method should be populated") | ||
| XCTAssertEqual(paymentMethod?.type, .sunbit, "Incorrect PaymentMethod type") | ||
| XCTAssertNotNil(paymentMethod?.sunbit, "The `sunbit` property must be populated") |
There was a problem hiding this comment.
This looks entirely redundant with the test in STPPaymentMethodFunctionalTest except for this line. Why did we start doing this..
Let's delete this file and add this line to STPPaymentMethodFunctionalTest.
Not a huge win but we should probably do the same for all the other "Params" tests that actually just create PMs :/ @davidme-stripe
Summary
Adding the Sunbit payment method to PaymentSheets and the API bindings. For information about Sunbit and why we're integrating it, check out its product brief and API review doc.
Motivation
Testing
Changelog
Screen.Recording.2024-06-28.at.9.18.43.AM.mov