Reanimate FC consent dots view on app foreground #3720
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-stripe
force-pushed
the
mats/reanimate_consent_view_on_foreground
branch
from
f284125
to
b1ecd4e
Compare
...cialConnections/StripeFinancialConnections/Source/Native/Consent/ConsentViewController.swift
Outdated
Show resolved
Hide resolved
...cialConnections/StripeFinancialConnections/Source/Native/Consent/ConsentViewController.swift
Show resolved
Hide resolved
| ) | ||
| } | ||
|
|
||
| @objc private func appWillEnterForeground() { |
There was a problem hiding this comment.
I like the straightforward naming! UIApplication.willEnterForegroundNotification > appWillEnterForeground is easy to understand (vs. naming it something more-specific like "reactiveDots" or else)
kgaidis-stripe
previously approved these changes
Jun 27, 2024
|
marking this as done: https://jira.corp.stripe.com/browse/BANKCON-10932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where the consent logo view dots animation would be stopped and not restarted when the app was backgrounded, then returned to the foreground.
Motivation
✨
Testing
Verified the animation properly continues after the app is foregrounded:
Screen.Recording.2024-06-27.at.1.21.11.PM.mov
Changelog
N/a